Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid load default engine if not being used #1136

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Avoid load default engine if not being used #1136

merged 1 commit into from
Aug 2, 2021

Conversation

frankfliu
Copy link
Contributor

Change-Id: I9c14b470306d9c1c7226c50952e439e2842ad01c

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu
Avoid load default engine if not being used
f35c405 
Change-Id: I9c14b470306d9c1c7226c50952e439e2842ad01c
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2021 •
edited
Loading

Codecov Report

Merging #1136 (f35c405) into master (21bf5fe) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1136   +/-   ##
=========================================
  Coverage     70.19%   70.19%           
- Complexity     5323     5324    +1     
=========================================
  Files           513      513           
  Lines         23622    23624    +2     
  Branches       2529     2529           
=========================================
+ Hits          16582    16584    +2     
  Misses         5695     5695           
  Partials       1345     1345
Impacted Files Coverage Δ
api/src/main/java/ai/djl/engine/Engine.java 35.95% <100.00%> (+0.72%) ⬆️
...ain/java/ai/djl/modality/cv/util/NDImageUtils.java 48.68% <100.00%> (-1.32%) ⬇️
...in/java/ai/djl/repository/zoo/BaseModelLoader.java 80.34% <100.00%> (ø)
...djl/training/listener/LoggingTrainingListener.java 88.59% <100.00%> (+0.10%) ⬆️
...mark/src/main/java/ai/djl/benchmark/Arguments.java 78.65% <100.00%> (+0.56%) ⬆️
.../src/main/java/ai/djl/fasttext/zoo/FtModelZoo.java 100.00% <100.00%> (ø)
api/src/main/java/ai/djl/repository/Artifact.java 89.65% <0.00%> (-1.73%) ⬇️
.../main/java/ai/djl/benchmark/AbstractBenchmark.java 92.39% <0.00%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21bf5fe...f35c405. Read the comment docs.

@frankfliu frankfliu merged commit 8183faf into deepjavalibrary:master Aug 2, 2021
@frankfliu frankfliu deleted the engine branch August 2, 2021 17:45
Lokiiiiii pushed a commit to Lokiiiiii/djl that referenced this pull request Oct 10, 2023
[vLLM][Handler] add quantization option for vLLM (deepjavalibrary#1136)
6523e1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanking520 lanking520 lanking520 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frankfliu @codecov-commenter @lanking520